Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of the adjoint of the fdiff function from ImageBase.jl #26

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

arcAman07
Copy link
Contributor

This PR deals with the addition of the adjoint ( AD ) for the fdiff function ( Forward Difference ) from ImageBase.jl. Adjoint is written for the function along with the corresponding tests. Tagging the mentors for review @johnnychen94 @DhairyaLGandhi .

@arcAman07
Copy link
Contributor Author

arcAman07 commented May 10, 2022

Not sure why some of the tests are not passing, they are working for me locally
image

@johnnychen94 johnnychen94 self-requested a review May 10, 2022 14:32
@johnnychen94 johnnychen94 self-assigned this May 10, 2022
Copy link
Collaborator

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at first look. Will check the details this weekend.

Project.toml Show resolved Hide resolved
@arcAman07
Copy link
Contributor Author

Looks good at first look. Will check the details this weekend.

Great!, will accordingly work on adding other adjoints for utility functions in ImageBase.jl

@arcAman07
Copy link
Contributor Author

Updated the fdiff adjoint by making it shorter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants